diff options
| author | James Chapman <jchapman@katalix.com> | 2012-04-10 04:10:42 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2012-04-13 19:01:44 +0400 |
| commit | d1f224ae186b834af647661ffaf403a817c050ce (patch) | |
| tree | ba97e12cf85c7f81e4829928ffdd5b4aad3e1fe7 /net/l2tp/l2tp_ip.c | |
| parent | 31304165ffb888483e0f7c805876f25f493a3049 (diff) | |
| download | linux-d1f224ae186b834af647661ffaf403a817c050ce.tar.xz | |
l2tp: fix refcount leak in l2tp_ip sockets
The l2tp_ip socket close handler does not update the module refcount
correctly which prevents module unload after the first bind() call on
an L2TPv3 IP encapulation socket.
Signed-off-by: James Chapman <jchapman@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/l2tp/l2tp_ip.c')
| -rw-r--r-- | net/l2tp/l2tp_ip.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/l2tp/l2tp_ip.c b/net/l2tp/l2tp_ip.c index 55670ec3cd0f..b56be1452f8e 100644 --- a/net/l2tp/l2tp_ip.c +++ b/net/l2tp/l2tp_ip.c @@ -232,7 +232,7 @@ static void l2tp_ip_close(struct sock *sk, long timeout) { write_lock_bh(&l2tp_ip_lock); hlist_del_init(&sk->sk_bind_node); - hlist_del_init(&sk->sk_node); + sk_del_node_init(sk); write_unlock_bh(&l2tp_ip_lock); sk_common_release(sk); } |