diff options
| author | Xiyu Yang <xiyuyang19@fudan.edu.cn> | 2020-07-25 11:02:18 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-07-29 03:24:08 +0300 |
| commit | 706ec919164622ff5ce822065472d0f30a9e9dd2 (patch) | |
| tree | e3cfda7e04b287deb5b8bcb137840e3267f90022 /net/ipv6/xfrm6_policy.c | |
| parent | fa662d7816a5a3790f3ee49f27e5f65991d3347d (diff) | |
| download | linux-706ec919164622ff5ce822065472d0f30a9e9dd2.tar.xz | |
ipv6: Fix nexthop refcnt leak when creating ipv6 route info
ip6_route_info_create() invokes nexthop_get(), which increases the
refcount of the "nh".
When ip6_route_info_create() returns, local variable "nh" becomes
invalid, so the refcount should be decreased to keep refcount balanced.
The reference counting issue happens in one exception handling path of
ip6_route_info_create(). When nexthops can not be used with source
routing, the function forgets to decrease the refcnt increased by
nexthop_get(), causing a refcnt leak.
Fix this issue by pulling up the error source routing handling when
nexthops can not be used with source routing.
Fixes: f88d8ea67fbd ("ipv6: Plumb support for nexthop object in a fib6_info")
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/xfrm6_policy.c')
0 files changed, 0 insertions, 0 deletions