diff options
author | Eric Dumazet <edumazet@google.com> | 2023-04-12 16:03:08 +0300 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2023-04-13 20:04:37 +0300 |
commit | 1c5950fc6fe996235f1d18539b9c6b64b597f50f (patch) | |
tree | 70d65ea09555a8eaa1a255c7655cc197e7634807 /net/ipv6/ip6_checksum.c | |
parent | 306dc21361993f4fe50a15d4db6b1a4de5d0adb0 (diff) | |
download | linux-1c5950fc6fe996235f1d18539b9c6b64b597f50f.tar.xz |
udp6: fix potential access to stale information
lena wang reported an issue caused by udpv6_sendmsg()
mangling msg->msg_name and msg->msg_namelen, which
are later read from ____sys_sendmsg() :
/*
* If this is sendmmsg() and sending to current destination address was
* successful, remember it.
*/
if (used_address && err >= 0) {
used_address->name_len = msg_sys->msg_namelen;
if (msg_sys->msg_name)
memcpy(&used_address->name, msg_sys->msg_name,
used_address->name_len);
}
udpv6_sendmsg() wants to pretend the remote address family
is AF_INET in order to call udp_sendmsg().
A fix would be to modify the address in-place, instead
of using a local variable, but this could have other side effects.
Instead, restore initial values before we return from udpv6_sendmsg().
Fixes: c71d8ebe7a44 ("net: Fix security_socket_sendmsg() bypass problem.")
Reported-by: lena wang <lena.wang@mediatek.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Maciej Żenczykowski <maze@google.com>
Link: https://lore.kernel.org/r/20230412130308.1202254-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/ipv6/ip6_checksum.c')
0 files changed, 0 insertions, 0 deletions