diff options
| author | Eric Dumazet <edumazet@google.com> | 2019-09-05 23:20:41 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-09-07 18:32:28 +0300 |
| commit | b58662a5f7f4677debd5e28d10145cf5decd516b (patch) | |
| tree | 32d0dcfaa1ed927c724a286773a3e47317f9f780 /net/ipv4/tcp_diag.c | |
| parent | 3dd97a08271f031bd54c61e65b6b0ebfb0c404b7 (diff) | |
| download | linux-b58662a5f7f4677debd5e28d10145cf5decd516b.tar.xz | |
tcp: ulp: fix possible crash in tcp_diag_get_aux_size()
tcp_diag_get_aux_size() can be called with sockets in any state.
icsk_ulp_ops is only present for full sockets.
For SYN_RECV or TIME_WAIT ones we would access garbage.
Fixes: 61723b393292 ("tcp: ulp: add functions to dump ulp-specific information")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Luke Hsiao <lukehsiao@google.com>
Reported-by: Neal Cardwell <ncardwell@google.com>
Cc: Davide Caratti <dcaratti@redhat.com>
Acked-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/tcp_diag.c')
| -rw-r--r-- | net/ipv4/tcp_diag.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/ipv4/tcp_diag.c b/net/ipv4/tcp_diag.c index babc156deabb..81a8221d650a 100644 --- a/net/ipv4/tcp_diag.c +++ b/net/ipv4/tcp_diag.c @@ -163,7 +163,7 @@ static size_t tcp_diag_get_aux_size(struct sock *sk, bool net_admin) } #endif - if (net_admin) { + if (net_admin && sk_fullsock(sk)) { const struct tcp_ulp_ops *ulp_ops; ulp_ops = icsk->icsk_ulp_ops; |