diff options
author | Petr Machata <petrm@nvidia.com> | 2021-02-09 20:52:04 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2021-02-12 00:10:44 +0300 |
commit | 1edb5cbf49a7464a575966ad6f48b3876fb64f63 (patch) | |
tree | 1b3ba91d447dcdd23aace1d865b513f18e19630d /net/ipv4/inet_hashtables.c | |
parent | 4217a64e18a1647a0dbc68cb3169a5a06f054ec8 (diff) | |
download | linux-1edb5cbf49a7464a575966ad6f48b3876fb64f63.tar.xz |
Revert "net-loopback: set lo dev initial state to UP"
In commit c9dca822c729 ("net-loopback: set lo dev initial state to UP"),
linux started automatically bringing up the loopback device of a newly
created namespace. However, an existing user script might reasonably have
the following stanza when creating a new namespace -- and in fact at least
tools/testing/selftests/net/fib_nexthops.sh in Linux's very own testsuite
does:
# set -e
# ip netns add foo
# ip -netns foo addr add 127.0.0.1/8 dev lo
# ip -netns foo link set lo up
# set +e
This will now fail, because the kernel reasonably rejects "ip addr add" of
a duplicate address. The described change of behavior therefore constitutes
a breakage. Revert it.
Fixes: c9dca822c729 ("net-loopback: set lo dev initial state to UP")
Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/inet_hashtables.c')
0 files changed, 0 insertions, 0 deletions