diff options
author | David Ahern <dsahern@gmail.com> | 2020-05-26 21:56:17 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2020-05-27 02:06:07 +0300 |
commit | af7888ad9edbd8ba7f6449d1c27ce281ad4b26fd (patch) | |
tree | dfbee9452e5f2673a01f531dc4332bfcbc68770f /net/ipv4/fib_frontend.c | |
parent | 0b5e2e39739e861fa5fc84ab27a35dbe62a15330 (diff) | |
download | linux-af7888ad9edbd8ba7f6449d1c27ce281ad4b26fd.tar.xz |
ipv4: Refactor nhc evaluation in fib_table_lookup
FIB lookups can return an entry that references an external nexthop.
While walking the nexthop struct we do not want to make multiple calls
into the nexthop code which can result in 2 different structs getting
accessed - one returning the number of paths the rest of the loop
seeing a different nh_grp struct. If the nexthop group shrunk, the
result is an attempt to access a fib_nh_common that does not exist for
the new nh_grp struct but did for the old one.
To fix that move the device evaluation code to a helper that can be
used for inline fib_nh path as well as external nexthops.
Update the existing check for fi->nh in fib_table_lookup to call a
new helper, nexthop_get_nhc_lookup, which walks the external nexthop
with a single rcu dereference.
Fixes: 430a049190de ("nexthop: Add support for nexthop groups")
Signed-off-by: David Ahern <dsahern@gmail.com>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv4/fib_frontend.c')
0 files changed, 0 insertions, 0 deletions