diff options
| author | Andrew Lunn <andrew@lunn.ch> | 2016-03-12 02:01:40 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2016-03-14 22:43:11 +0300 |
| commit | 5bcbe0f35fb13e31fdd0b2dc9695f19ab0208207 (patch) | |
| tree | 43a275f2ab4cfcdfefd2da7e376063080994beb2 /net/dsa | |
| parent | ec777e6b4254648be51146d4e7d735ee3d06bd13 (diff) | |
| download | linux-5bcbe0f35fb13e31fdd0b2dc9695f19ab0208207.tar.xz | |
phy: fixed: Fix removal of phys.
The fixed phys delete function simply removed the fixed phy from the
internal linked list and freed the memory. It however did not
unregister the associated phy device. This meant it was still possible
to find the phy device on the mdio bus.
Make fixed_phy_del() an internal function and add a
fixed_phy_unregister() to unregisters the phy device and then uses
fixed_phy_del() to free resources.
Modify DSA to use this new API function, so we don't leak phys.
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dsa')
| -rw-r--r-- | net/dsa/dsa.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c index f100f340d93f..c28c47463b7e 100644 --- a/net/dsa/dsa.c +++ b/net/dsa/dsa.c @@ -447,11 +447,9 @@ static void dsa_switch_destroy(struct dsa_switch *ds) if (of_phy_is_fixed_link(port_dn)) { phydev = of_phy_find_device(port_dn); if (phydev) { - int addr = phydev->mdio.addr; - phy_device_free(phydev); of_node_put(port_dn); - fixed_phy_del(addr); + fixed_phy_unregister(phydev); } } } |