diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2018-12-11 23:10:08 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-12-15 02:34:28 +0300 |
| commit | 69d2c86766da2ded2b70281f1bf242cb0d58a778 (patch) | |
| tree | 2dff5a7d1cb78ea10ed065a738fa4ba991ec3eac /net/dns_resolver | |
| parent | 51367e423c6501a26e67d91a655d2bc892303462 (diff) | |
| download | linux-69d2c86766da2ded2b70281f1bf242cb0d58a778.tar.xz | |
ip6mr: Fix potential Spectre v1 vulnerability
vr.mifi is indirectly controlled by user-space, hence leading to
a potential exploitation of the Spectre variant 1 vulnerability.
This issue was detected with the help of Smatch:
net/ipv6/ip6mr.c:1845 ip6mr_ioctl() warn: potential spectre issue 'mrt->vif_table' [r] (local cap)
net/ipv6/ip6mr.c:1919 ip6mr_compat_ioctl() warn: potential spectre issue 'mrt->vif_table' [r] (local cap)
Fix this by sanitizing vr.mifi before using it to index mrt->vif_table'
Notice that given that speculation windows are large, the policy is
to kill the speculation on the first load and not worry if it can be
completed with a dependent load/store [1].
[1] https://marc.info/?l=linux-kernel&m=152449131114778&w=2
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/dns_resolver')
0 files changed, 0 insertions, 0 deletions