diff options
| author | Eric Dumazet <eric.dumazet@gmail.com> | 2010-10-13 08:43:04 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2010-10-16 22:13:22 +0400 |
| commit | a0a4a85a15df6335e3d11f83b2ac06ebebea313f (patch) | |
| tree | f4b09caa75228520d8631dc4e0c5ce1953ec6461 /net/core | |
| parent | 2c1c00040af3d187b7d602dd53b5adbbf3a4caa4 (diff) | |
| download | linux-a0a4a85a15df6335e3d11f83b2ac06ebebea313f.tar.xz | |
fib: remove a useless synchronize_rcu() call
fib_nl_delrule() calls synchronize_rcu() for no apparent reason,
while rtnl is held.
I suspect it was done to avoid an atomic_inc_not_zero() in
fib_rules_lookup(), which commit 7fa7cb7109d07 added anyway.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
| -rw-r--r-- | net/core/fib_rules.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/net/core/fib_rules.c b/net/core/fib_rules.c index 21698f8c49ee..1bc3f253ba6c 100644 --- a/net/core/fib_rules.c +++ b/net/core/fib_rules.c @@ -494,7 +494,6 @@ static int fib_nl_delrule(struct sk_buff *skb, struct nlmsghdr* nlh, void *arg) } } - synchronize_rcu(); notify_rule_change(RTM_DELRULE, rule, ops, nlh, NETLINK_CB(skb).pid); fib_rule_put(rule); |