diff options
| author | James Chapman <jchapman@katalix.com> | 2008-12-17 15:02:16 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-12-19 06:41:42 +0300 |
| commit | 739840d529eb7505d3cbfe9d468bf1440c9a8e27 (patch) | |
| tree | 432ffe292f8886a63f1328e6e2466c01dbe452d5 /net/core/netpoll.c | |
| parent | 1b08534e562dae7b084326f8aa8cc12a4c1b6593 (diff) | |
| download | linux-739840d529eb7505d3cbfe9d468bf1440c9a8e27.tar.xz | |
ppp: fix segfaults introduced by netdev_priv changes
This patch fixes a segfault in ppp_shutdown_interface() and
ppp_destroy_interface() when a PPP connection is closed. I bisected
the problem to the following commit:
commit c8019bf3aff653cceb64f66489fc299ee5957b57
Author: Wang Chen <wangchen@cn.fujitsu.com>
Date: Thu Nov 20 04:24:17 2008 -0800
netdevice ppp: Convert directly reference of netdev->priv
1. Use netdev_priv(dev) to replace dev->priv.
2. Alloc netdev's private data by alloc_netdev().
Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
The original ppp_generic code treated the netdev and struct ppp as
independent data structures which were freed separately. In moving the
ppp struct into the netdev, it is now possible for the private data to
be freed before the call to ppp_shutdown_interface(), which is bad.
The kfree(ppp) in ppp_destroy_interface() is also wrong; presumably
ppp hasn't worked since the above commit.
The following patch fixes both problems.
Signed-off-by: James Chapman <jchapman@katalix.com>
Reviewed-by: Wang Chen <wangchen@cn.fujitsu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/netpoll.c')
0 files changed, 0 insertions, 0 deletions