diff options
| author | Russell King (Oracle) <rmk+kernel@armlinux.org.uk> | 2022-01-17 17:52:33 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-01-17 19:30:44 +0300 |
| commit | 5765cee119bf5a36c94d20eceb37c445508934be (patch) | |
| tree | a8b4b4e8d0d275c0e6ee914f9c21e7928358f7e5 /net/core/net_namespace.c | |
| parent | 9ea674d7ca4f6ce080b813ac2d9a9397f13d2427 (diff) | |
| download | linux-5765cee119bf5a36c94d20eceb37c445508934be.tar.xz | |
net: sfp: fix high power modules without diagnostic monitoring
Commit 7cfa9c92d0a3 ("net: sfp: avoid power switch on address-change
modules") unintetionally changed the semantics for high power modules
without the digital diagnostics monitoring. We repeatedly attempt to
read the power status from the non-existing 0xa2 address in a futile
hope this failure is temporary:
[ 8.856051] sfp sfp-eth3: module NTT 0000000000000000 rev 0000 sn 0000000000000000 dc 160408
[ 8.865843] mvpp2 f4000000.ethernet eth3: switched to inband/1000base-x link mode
[ 8.873469] sfp sfp-eth3: Failed to read EEPROM: -5
[ 8.983251] sfp sfp-eth3: Failed to read EEPROM: -5
[ 9.103250] sfp sfp-eth3: Failed to read EEPROM: -5
We previosuly assumed such modules were powered up in the correct mode,
continuing without further configuration as long as the required power
class was supported by the host.
Restore this behaviour, while preserving the intent of subsequent
patches to avoid the "Address Change Sequence not supported" warning
if we are not going to be accessing the DDM address.
Fixes: 7cfa9c92d0a3 ("net: sfp: avoid power switch on address-change modules")
Reported-by: 照山周一郎 <teruyama@springboard-inc.jp>
Tested-by: 照山周一郎 <teruyama@springboard-inc.jp>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/net_namespace.c')
0 files changed, 0 insertions, 0 deletions