summaryrefslogtreecommitdiff
path: root/net/ceph
diff options
context:
space:
mode:
authorJohannes Weiner <hannes@cmpxchg.org>2016-03-18 00:20:28 +0300
committerLinus Torvalds <torvalds@linux-foundation.org>2016-03-18 01:09:34 +0300
commitb6e6edcfa40561e9c8abe5eecf1c96f8e5fd9c6f (patch)
tree4827a7b163fc3b97c8ae86d31315f1e508b5753c /net/ceph
parent588083bb37a3cea8533c392370a554417c8f29cb (diff)
downloadlinux-b6e6edcfa40561e9c8abe5eecf1c96f8e5fd9c6f.tar.xz
mm: memcontrol: reclaim and OOM kill when shrinking memory.max below usage
Setting the original memory.limit_in_bytes hardlimit is subject to a race condition when the desired value is below the current usage. The code tries a few times to first reclaim and then see if the usage has dropped to where we would like it to be, but there is no locking, and the workload is free to continue making new charges up to the old limit. Thus, attempting to shrink a workload relies on pure luck and hope that the workload happens to cooperate. To fix this in the cgroup2 memory.max knob, do it the other way round: set the limit first, then try enforcement. And if reclaim is not able to succeed, trigger OOM kills in the group. Keep going until the new limit is met, we run out of OOM victims and there's only unreclaimable memory left, or the task writing to memory.max is killed. This allows users to shrink groups reliably, and the behavior is consistent with what happens when new charges are attempted in excess of memory.max. Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> Acked-by: Michal Hocko <mhocko@suse.com> Cc: Vladimir Davydov <vdavydov@virtuozzo.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/ceph')
0 files changed, 0 insertions, 0 deletions