diff options
| author | Stephen Hemminger <shemminger@osdl.org> | 2006-01-04 01:35:54 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2006-01-04 01:35:54 +0300 |
| commit | 554c9a8ec37729bff69951cb740074abbae21afa (patch) | |
| tree | f327e7dfc005da2d6792896525f5269308503e0b /net/bridge/br_stp_if.c | |
| parent | e84a9f5e9cd2b229dda24002334bc3cd36c1109d (diff) | |
| download | linux-554c9a8ec37729bff69951cb740074abbae21afa.tar.xz | |
[BRIDGE]: Fix faulty check in br_stp_recalculate_bridge_id()
One of the conversions from memcmp to compare_ether_addr is incorrect.
We need to do relative comparison to determine min MAC address to
use in bridge id.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge/br_stp_if.c')
| -rw-r--r-- | net/bridge/br_stp_if.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c index 2d2e969ae25d..cc047f7fb6ef 100644 --- a/net/bridge/br_stp_if.c +++ b/net/bridge/br_stp_if.c @@ -157,7 +157,7 @@ void br_stp_recalculate_bridge_id(struct net_bridge *br) list_for_each_entry(p, &br->port_list, list) { if (addr == br_mac_zero || - compare_ether_addr(p->dev->dev_addr, addr) < 0) + memcmp(p->dev->dev_addr, addr, ETH_ALEN) < 0) addr = p->dev->dev_addr; } |