diff options
author | Marek Lindner <mareklindner@neomailbox.ch> | 2015-07-25 23:37:15 +0300 |
---|---|---|
committer | Antonio Quartulli <antonio@meshcoding.com> | 2015-08-27 21:15:30 +0300 |
commit | f729dc70dafec281e524f51ae496a72ea4f8e319 (patch) | |
tree | ca910c0459ac63af7f3f047e01b175b8052407ed /net/batman-adv/bat_iv_ogm.c | |
parent | 1dd34b5ad8aebaff17b625fc0126e18243008a3f (diff) | |
download | linux-f729dc70dafec281e524f51ae496a72ea4f8e319.tar.xz |
batman-adv: move hardif refcount inc to batadv_neigh_node_new()
The batadv_neigh_node cleanup function 'batadv_neigh_node_free_rcu()'
takes care of reducing the hardif refcounter, hence it's only logical
to assume the creating function of that same object
'batadv_neigh_node_new()' takes care of increasing the same refcounter.
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Acked-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
Diffstat (limited to 'net/batman-adv/bat_iv_ogm.c')
-rw-r--r-- | net/batman-adv/bat_iv_ogm.c | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/net/batman-adv/bat_iv_ogm.c b/net/batman-adv/bat_iv_ogm.c index 5c122000688f..b9b8b333b363 100644 --- a/net/batman-adv/bat_iv_ogm.c +++ b/net/batman-adv/bat_iv_ogm.c @@ -303,12 +303,6 @@ batadv_iv_ogm_neigh_new(struct batadv_hard_iface *hard_iface, if (!neigh_node) goto out; - if (!atomic_inc_not_zero(&hard_iface->refcount)) { - kfree(neigh_node); - neigh_node = NULL; - goto out; - } - neigh_node->orig_node = orig_neigh; neigh_node->if_incoming = hard_iface; |