diff options
author | Eric Dumazet <edumazet@google.com> | 2015-04-17 04:10:35 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-04-17 20:28:31 +0300 |
commit | 521f1cf1dbb9d5ad858dca5dc75d1b45f64b6589 (patch) | |
tree | 2c6276958f5d7348616d887f4a64f5b78ec6b9ef /net/ax25/ax25_ds_subr.c | |
parent | fad9dfefea6405039491e7e4fc21fb6e59e7d26c (diff) | |
download | linux-521f1cf1dbb9d5ad858dca5dc75d1b45f64b6589.tar.xz |
inet_diag: fix access to tcp cc information
Two different problems are fixed here :
1) inet_sk_diag_fill() might be called without socket lock held.
icsk->icsk_ca_ops can change under us and module be unloaded.
-> Access to freed memory.
Fix this using rcu_read_lock() to prevent module unload.
2) Some TCP Congestion Control modules provide information
but again this is not safe against icsk->icsk_ca_ops
change and nla_put() errors were ignored. Some sockets
could not get the additional info if skb was almost full.
Fix this by returning a status from get_info() handlers and
using rcu protection as well.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ax25/ax25_ds_subr.c')
0 files changed, 0 insertions, 0 deletions