summaryrefslogtreecommitdiff
path: root/mm
diff options
context:
space:
mode:
authorPatrick McHardy <kaber@trash.net>2008-01-21 04:25:14 +0300
committerDavid S. Miller <davem@davemloft.net>2008-01-21 07:31:45 +0300
commit68365458a4252fa993b91a00f7a0b18fed399f0d (patch)
tree824b1f32ba3b955c018626127602c365f986ccfc /mm
parentd4782c323d10d3698b71b6a6b3c7bdad33824658 (diff)
downloadlinux-68365458a4252fa993b91a00f7a0b18fed399f0d.tar.xz
[NET]: rtnl_link: fix use-after-free
When unregistering the rtnl_link_ops, all existing devices using the ops are destroyed. With nested devices this may lead to a use-after-free despite the use of for_each_netdev_safe() in case the upper device is next in the device list and is destroyed by the NETDEV_UNREGISTER notifier. The easy fix is to restart scanning the device list after removing a device. Alternatively we could add new devices to the front of the list to avoid having dependant devices follow the device they depend on. A third option would be to only restart scanning if dev->iflink of the next device matches dev->ifindex of the current one. For now this seems like the safest solution. With this patch, the veth rtnl_link_ops unregistration can use rtnl_link_unregister() directly since it now also handles destruction of multiple devices at once. Signed-off-by: Patrick McHardy <kaber@trash.net> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions