diff options
author | Jeff Layton <jlayton@redhat.com> | 2017-05-25 13:39:52 +0300 |
---|---|---|
committer | David Sterba <dsterba@suse.com> | 2017-06-19 19:26:01 +0300 |
commit | 3189ff778630d9ce8a9f2fda9f8ae4510cceb154 (patch) | |
tree | 3a54d9e4db65217606a47189b0c11ced8094e8d1 /lib/smp_processor_id.c | |
parent | 118c701e20ad6edfb35fd83ec6989991714b1d89 (diff) | |
download | linux-3189ff778630d9ce8a9f2fda9f8ae4510cceb154.tar.xz |
btrfs: btrfs_wait_tree_block_writeback can be void return
Nothing checks its return value.
Is it safe to skip checking return value of btrfs_wait_tree_block_writeback?
Liu Bo: I think yes, it's used in walk_log_tree which is called in two
places, free_log_tree and log replay. For free_log_tree, it waits for
any running writeback of the extent buffer under freeing to finish in
case we need to access the eb pointer from page->private, and it's OK to
not check the return value, while for log replay, it's doesn't wait
because wc->wait is not set. So neither cares about the writeback error.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
[ added more explanation to changelog, from Liu Bo ]
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'lib/smp_processor_id.c')
0 files changed, 0 insertions, 0 deletions