diff options
| author | Jan Kara <jack@suse.cz> | 2014-08-07 03:03:28 +0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2014-08-07 05:01:12 +0400 |
| commit | 5838d4442bd5971687b72221736222637e03140d (patch) | |
| tree | e639967a7baf1b1c6a0d1b5e0babc8083c7faad4 /lib/halfmd4.c | |
| parent | 8ba8fa917093510cdcb4ec8ff8b9603e1b525658 (diff) | |
| download | linux-5838d4442bd5971687b72221736222637e03140d.tar.xz | |
fanotify: fix double free of pending permission events
Commit 85816794240b ("fanotify: Fix use after free for permission
events") introduced a double free issue for permission events which are
pending in group's notification queue while group is being destroyed.
These events are freed from fanotify_handle_event() but they are not
removed from groups notification queue and thus they get freed again
from fsnotify_flush_notify().
Fix the problem by removing permission events from notification queue
before freeing them if we skip processing access response. Also expand
comments in fanotify_release() to explain group shutdown in detail.
Fixes: 85816794240b9659e66e4d9b0df7c6e814e5f603
Signed-off-by: Jan Kara <jack@suse.cz>
Reported-by: Douglas Leeder <douglas.leeder@sophos.com>
Tested-by: Douglas Leeder <douglas.leeder@sophos.com>
Reported-by: Heinrich Schuchard <xypron.glpk@gmx.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib/halfmd4.c')
0 files changed, 0 insertions, 0 deletions