diff options
| author | Johan Hovold <johan@kernel.org> | 2025-09-24 11:02:07 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2025-10-29 16:01:11 +0300 |
| commit | ee747d85cfcc8433ea0be6d49801aba9a48e5439 (patch) | |
| tree | 829ee27d11378a7ac8281449a30e638892e64276 /lib/genalloc.c | |
| parent | e7da4cfedc6e9f58375651dfda5b8c4baec679c6 (diff) | |
| download | linux-ee747d85cfcc8433ea0be6d49801aba9a48e5439.tar.xz | |
lib/genalloc: fix device leak in of_gen_pool_get()
commit 1260cbcffa608219fc9188a6cbe9c45a300ef8b5 upstream.
Make sure to drop the reference taken when looking up the genpool platform
device in of_gen_pool_get() before returning the pool.
Note that holding a reference to a device does typically not prevent its
devres managed resources from being released so there is no point in
keeping the reference.
Link: https://lkml.kernel.org/r/20250924080207.18006-1-johan@kernel.org
Fixes: 9375db07adea ("genalloc: add devres support, allow to find a managed pool by device")
Signed-off-by: Johan Hovold <johan@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Vladimir Zapolskiy <vz@mleia.com>
Cc: <stable@vger.kernel.org> [3.10+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib/genalloc.c')
| -rw-r--r-- | lib/genalloc.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/lib/genalloc.c b/lib/genalloc.c index dab97bb69df6..820e6bc687c3 100644 --- a/lib/genalloc.c +++ b/lib/genalloc.c @@ -893,8 +893,11 @@ struct gen_pool *of_gen_pool_get(struct device_node *np, if (!name) name = np_pool->name; } - if (pdev) + if (pdev) { pool = gen_pool_get(&pdev->dev, name); + put_device(&pdev->dev); + } + of_node_put(np_pool); return pool; |