summaryrefslogtreecommitdiff
path: root/io_uring
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@linaro.org>2023-12-05 15:37:17 +0300
committerJens Axboe <axboe@kernel.dk>2023-12-05 16:59:56 +0300
commite53f7b54b1fdecae897f25002ff0cff04faab228 (patch)
tree2e310edfc7a9755e4c4182cb9a07d99dc9c83ad9 /io_uring
parentf7b32e785042d2357c5abc23ca6db1b92c91a070 (diff)
downloadlinux-e53f7b54b1fdecae897f25002ff0cff04faab228.tar.xz
io_uring/kbuf: Fix an NULL vs IS_ERR() bug in io_alloc_pbuf_ring()
The io_mem_alloc() function returns error pointers, not NULL. Update the check accordingly. Fixes: b10b73c102a2 ("io_uring/kbuf: recycle freed mapped buffer ring entries") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/5ed268d3-a997-4f64-bd71-47faa92101ab@moroto.mountain Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'io_uring')
-rw-r--r--io_uring/kbuf.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/io_uring/kbuf.c b/io_uring/kbuf.c
index 268788305b61..bd25bc2deeaf 100644
--- a/io_uring/kbuf.c
+++ b/io_uring/kbuf.c
@@ -636,8 +636,8 @@ static int io_alloc_pbuf_ring(struct io_ring_ctx *ctx,
ibf = io_lookup_buf_free_entry(ctx, ring_size);
if (!ibf) {
ptr = io_mem_alloc(ring_size);
- if (!ptr)
- return -ENOMEM;
+ if (IS_ERR(ptr))
+ return PTR_ERR(ptr);
/* Allocate and store deferred free entry */
ibf = kmalloc(sizeof(*ibf), GFP_KERNEL_ACCOUNT);