summaryrefslogtreecommitdiff
path: root/init
diff options
context:
space:
mode:
authorMichal Kubecek <mkubecek@suse.cz>2018-12-13 19:23:32 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-01-09 19:38:32 +0300
commitd5f9565c8d5ad3cf94982223cfcef1169b0bb60f (patch)
treee860e16cbfd60f0d21d8c61223bb5c934515bbb7 /init
parentacb70d28fe63e5bf9795e935a382d4705f102056 (diff)
downloadlinux-d5f9565c8d5ad3cf94982223cfcef1169b0bb60f.tar.xz
net: ipv4: do not handle duplicate fragments as overlapping
[ Upstream commit ade446403bfb79d3528d56071a84b15351a139ad ] Since commit 7969e5c40dfd ("ip: discard IPv4 datagrams with overlapping segments.") IPv4 reassembly code drops the whole queue whenever an overlapping fragment is received. However, the test is written in a way which detects duplicate fragments as overlapping so that in environments with many duplicate packets, fragmented packets may be undeliverable. Add an extra test and for (potentially) duplicate fragment, only drop the new fragment rather than the whole queue. Only starting offset and length are checked, not the contents of the fragments as that would be too expensive. For similar reason, linear list ("run") of a rbtree node is not iterated, we only check if the new fragment is a subset of the interval covered by existing consecutive fragments. v2: instead of an exact check iterating through linear list of an rbtree node, only check if the new fragment is subset of the "run" (suggested by Eric Dumazet) Fixes: 7969e5c40dfd ("ip: discard IPv4 datagrams with overlapping segments.") Signed-off-by: Michal Kubecek <mkubecek@suse.cz> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'init')
0 files changed, 0 insertions, 0 deletions