diff options
| author | Al Viro <viro@ZenIV.linux.org.uk> | 2014-09-12 23:56:04 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2014-10-06 00:41:08 +0400 |
| commit | 778c29354bf7566af2c9a452933618758e32ef83 (patch) | |
| tree | 17e6db42e46c9f7cc518732e5c4c301d8e0bee05 /init | |
| parent | 60ede3e7d31ef63d8ed1ebc847b0290ad6f3f5f7 (diff) | |
| download | linux-778c29354bf7566af2c9a452933618758e32ef83.tar.xz | |
GFS2: fix d_splice_alias() misuses
commit cfb2f9d5c921e38b0f12bb26fed10b877664444d upstream.
Callers of d_splice_alias(dentry, inode) don't need iput(), neither
on success nor on failure. Either the reference to inode is stored
in a previously negative dentry, or it's dropped. In either case
inode reference the caller used to hold is consumed.
__gfs2_lookup() does iput() in case when d_splice_alias() has failed.
Double iput() if we ever hit that. And gfs2_create_inode() ends up
not only with double iput(), but with link count dropped to zero - on
an inode it has just found in directory.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'init')
0 files changed, 0 insertions, 0 deletions