summaryrefslogtreecommitdiff
path: root/include
diff options
context:
space:
mode:
authorJann Horn <jannh@google.com>2019-02-19 00:43:09 +0300
committerMichal Simek <michal.simek@xilinx.com>2019-03-18 15:43:54 +0300
commitb9472f7d8224460499dd7128ec944735ed5345a0 (patch)
treef2410aed6f9d4aaaf3d299d62fc5caae126a6080 /include
parent9e98c678c2d6ae3a17cb2de55d17f69dddaa231b (diff)
downloadlinux-b9472f7d8224460499dd7128ec944735ed5345a0.tar.xz
firmware: xilinx: fix debugfs write handler
- Userspace wants to write a string with `len` bytes, not counting the terminating NULL, so we should allocate `len+1` bytes. It looks like the current code relied on having a nullbyte directly behind `kern_buff`, which happens to work reliably as long as `len` isn't one of the kmalloc size classes. - strncpy_from_user() is completely wrong here; userspace is giving us a (not necessarily null-terminated) buffer and its length. strncpy_from_user() is for cases in which we don't know the length. - Don't let broken userspace allocate arbitrarily big kmalloc allocations. Just use memdup_user_nul(), which is designed precisely for things like this. Signed-off-by: Jann Horn <jannh@google.com> Acked-by: Jolly Shah <jolly.shah@xilinx.com> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions