summaryrefslogtreecommitdiff
path: root/include/uapi/linux/netlink_diag.h
diff options
context:
space:
mode:
authorNicolas Dichtel <nicolas.dichtel@6wind.com>2013-11-28 21:31:05 +0400
committerDavid S. Miller <davem@davemloft.net>2013-11-29 03:16:43 +0400
commit31e20bad8d5871c6f8673c28ea26ab7a0e520086 (patch)
treeef6bcbdf299368ce10c909aeff6302588f17f656 /include/uapi/linux/netlink_diag.h
parent2c7a9dc1641664173211c4ebc5db510a08684c46 (diff)
downloadlinux-31e20bad8d5871c6f8673c28ea26ab7a0e520086.tar.xz
diag: warn about missing first netlink attribute
The first netlink attribute (value 0) must always be defined as none/unspec. This is correctly done in inet_diag.h, but other diag interfaces are wrong. Because we cannot change an existing API, I add a comment to point the mistake and avoid to propagate it in a new diag API in the future. CC: Thomas Graf <tgraf@suug.ch> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> Acked-by: Thomas Graf <tgraf@suug.ch> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/uapi/linux/netlink_diag.h')
-rw-r--r--include/uapi/linux/netlink_diag.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/include/uapi/linux/netlink_diag.h b/include/uapi/linux/netlink_diag.h
index 4e31db4eea41..f2159d30d1f5 100644
--- a/include/uapi/linux/netlink_diag.h
+++ b/include/uapi/linux/netlink_diag.h
@@ -33,6 +33,7 @@ struct netlink_diag_ring {
};
enum {
+ /* NETLINK_DIAG_NONE, standard nl API requires this attribute! */
NETLINK_DIAG_MEMINFO,
NETLINK_DIAG_GROUPS,
NETLINK_DIAG_RX_RING,