diff options
| author | Bart Van Assche <bart.vanassche@wdc.com> | 2018-06-16 00:55:18 +0300 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2018-07-09 18:07:52 +0300 |
| commit | b3e7e7d2d668de0102264302a4d10dd9d4438a42 (patch) | |
| tree | 3c24f315b9878a28e97e804262f64c70f1425ce7 /include/uapi/linux/blkzoned.h | |
| parent | f441108fa08c466d986a7dca776f59dabab58456 (diff) | |
| download | linux-b3e7e7d2d668de0102264302a4d10dd9d4438a42.tar.xz | |
include/uapi/linux/blkzoned.h: Remove a superfluous __packed directive
Using the __packed directive for a structure that does not need
it is wrong because it makes gcc generate suboptimal code on some
architectures. Hence remove the __packed directive from the
blk_zone_report structure definition. See also
http://digitalvampire.org/blog/index.php/2006/07/31/why-you-shouldnt-use-__attribute__packed/.
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
Cc: Matias Bjorling <mb@lightnvm.io>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'include/uapi/linux/blkzoned.h')
| -rw-r--r-- | include/uapi/linux/blkzoned.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/uapi/linux/blkzoned.h b/include/uapi/linux/blkzoned.h index e3c70fe6bf0f..ff5a5db8906a 100644 --- a/include/uapi/linux/blkzoned.h +++ b/include/uapi/linux/blkzoned.h @@ -117,7 +117,7 @@ struct blk_zone_report { __u32 nr_zones; __u8 reserved[4]; struct blk_zone zones[0]; -} __packed; +}; /** * struct blk_zone_range - BLKRESETZONE ioctl request |