summaryrefslogtreecommitdiff
path: root/include/soc
diff options
context:
space:
mode:
authorTomi Valkeinen <tomi.valkeinen@ti.com>2018-09-26 19:11:22 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-10-13 10:27:23 +0300
commitf66d89483bb301bd7a73ccc96204f1026b15151f (patch)
treebac856a5f6256ec74105e5e703a1a2771cf86c48 /include/soc
parent887361696fb9e2c5b99e39c8d0dbacbe46ff92f9 (diff)
downloadlinux-f66d89483bb301bd7a73ccc96204f1026b15151f.tar.xz
fbdev/omapfb: fix omapfb_memory_read infoleak
commit 1bafcbf59fed92af58955024452f45430d3898c5 upstream. OMAPFB_MEMORY_READ ioctl reads pixels from the LCD's memory and copies them to a userspace buffer. The code has two issues: - The user provided width and height could be large enough to overflow the calculations - The copy_to_user() can copy uninitialized memory to the userspace, which might contain sensitive kernel information. Fix these by limiting the width & height parameters, and only copying the amount of data that we actually received from the LCD. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Reported-by: Jann Horn <jannh@google.com> Cc: stable@vger.kernel.org Cc: security@kernel.org Cc: Will Deacon <will.deacon@arm.com> Cc: Jann Horn <jannh@google.com> Cc: Tony Lindgren <tony@atomide.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/soc')
0 files changed, 0 insertions, 0 deletions