diff options
| author | Kuniyuki Iwashima <kuniyu@amazon.com> | 2022-07-13 23:51:55 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-07-29 18:14:11 +0300 |
| commit | 281de3719986af659186e2bbef2f169753391a05 (patch) | |
| tree | b078985981c6002d35e8566173dc35322ac2de30 /include/net | |
| parent | 7828309df0f89419a9349761a37c7d1b0da45697 (diff) | |
| download | linux-281de3719986af659186e2bbef2f169753391a05.tar.xz | |
ip: Fix data-races around sysctl_ip_nonlocal_bind.
[ Upstream commit 289d3b21fb0bfc94c4e98f10635bba1824e5f83c ]
While reading sysctl_ip_nonlocal_bind, it can be changed concurrently.
Thus, we need to add READ_ONCE() to its readers.
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'include/net')
| -rw-r--r-- | include/net/inet_sock.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/inet_sock.h b/include/net/inet_sock.h index 34c4436fd18f..40f92f5a3047 100644 --- a/include/net/inet_sock.h +++ b/include/net/inet_sock.h @@ -375,7 +375,7 @@ static inline bool inet_get_convert_csum(struct sock *sk) static inline bool inet_can_nonlocal_bind(struct net *net, struct inet_sock *inet) { - return net->ipv4.sysctl_ip_nonlocal_bind || + return READ_ONCE(net->ipv4.sysctl_ip_nonlocal_bind) || inet->freebind || inet->transparent; } |