diff options
author | Eric Dumazet <edumazet@google.com> | 2018-10-10 22:29:58 +0300 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-10-18 10:13:24 +0300 |
commit | 49106f36c253a3c4ce7cf297415826af0c4339ea (patch) | |
tree | e6490841efc12b3aaccaa6d4226356b05ea3d5ae /include/net | |
parent | ea7496f018adcfbac5396ead5756dcabb9866749 (diff) | |
download | linux-49106f36c253a3c4ce7cf297415826af0c4339ea.tar.xz |
inet: frags: get rif of inet_frag_evicting()
This refactors ip_expire() since one indentation level is removed.
Note: in the future, we should try hard to avoid the skb_clone()
since this is a serious performance cost.
Under DDOS, the ICMP message wont be sent because of rate limits.
Fact that ip6_expire_frag_queue() does not use skb_clone() is
disturbing too. Presumably IPv6 should have the same
issue than the one we fixed in commit ec4fbd64751d
("inet: frag: release spinlock before calling icmp_send()")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
(cherry picked from commit 399d1404be660d355192ff4df5ccc3f4159ec1e4)
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/net')
-rw-r--r-- | include/net/inet_frag.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/include/net/inet_frag.h b/include/net/inet_frag.h index a49cdf25cef0..7e984045b2b7 100644 --- a/include/net/inet_frag.h +++ b/include/net/inet_frag.h @@ -118,11 +118,6 @@ static inline void inet_frag_put(struct inet_frag_queue *q) inet_frag_destroy(q); } -static inline bool inet_frag_evicting(struct inet_frag_queue *q) -{ - return false; -} - /* Memory Tracking Functions. */ static inline int frag_mem_limit(struct netns_frags *nf) |