diff options
| author | David S. Miller <davem@davemloft.net> | 2008-08-13 13:13:34 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2008-08-13 13:13:34 +0400 |
| commit | 83f36f3f35f4f83fa346bfff58a5deabc78370e5 (patch) | |
| tree | 6e3c252967f33b76a60585c2702878c153649fbc /include/net/pkt_sched.h | |
| parent | 5e0115e500fe9dd2ca11e6f92db9123204f1327a (diff) | |
| download | linux-83f36f3f35f4f83fa346bfff58a5deabc78370e5.tar.xz | |
pkt_sched: Add queue stopped test back to qdisc_run().
Based upon a bug report by Andrew Gallatin on netdev
with subject "CPU utilization increased in 2.6.27rc"
In commit 37437bb2e1ae8af470dfcd5b4ff454110894ccaf
("pkt_sched: Schedule qdiscs instead of netdev_queue.")
the test of the queue being stopped was erroneously
removed from qdisc_run().
When the TX queue of the device fills up, this omission
causes lots of extraneous useless work to be queued up
to softirq context, where we'll just return immediately
because the device is still stuffed up.
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/pkt_sched.h')
| -rw-r--r-- | include/net/pkt_sched.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/include/net/pkt_sched.h b/include/net/pkt_sched.h index 6affcfaa123e..853fe83d9f37 100644 --- a/include/net/pkt_sched.h +++ b/include/net/pkt_sched.h @@ -89,7 +89,10 @@ extern void __qdisc_run(struct Qdisc *q); static inline void qdisc_run(struct Qdisc *q) { - if (!test_and_set_bit(__QDISC_STATE_RUNNING, &q->state)) + struct netdev_queue *txq = q->dev_queue; + + if (!netif_tx_queue_stopped(txq) && + !test_and_set_bit(__QDISC_STATE_RUNNING, &q->state)) __qdisc_run(q); } |