diff options
| author | Eric Dumazet <edumazet@google.com> | 2020-01-06 17:10:39 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2020-01-08 23:40:47 +0300 |
| commit | d9e15a2733067c9328fb56d98fe8e574fa19ec31 (patch) | |
| tree | fcba680930ee393e0c16aa75b782975674cba89c /include/net/llc_c_ac.h | |
| parent | b969fee12b6330fd6a0b15337a314d5b5ee56916 (diff) | |
| download | linux-d9e15a2733067c9328fb56d98fe8e574fa19ec31.tar.xz | |
pkt_sched: fq: do not accept silly TCA_FQ_QUANTUM
As diagnosed by Florian :
If TCA_FQ_QUANTUM is set to 0x80000000, fq_deueue()
can loop forever in :
if (f->credit <= 0) {
f->credit += q->quantum;
goto begin;
}
... because f->credit is either 0 or -2147483648.
Let's limit TCA_FQ_QUANTUM to no more than 1 << 20 :
This max value should limit risks of breaking user setups
while fixing this bug.
Fixes: afe4fd062416 ("pkt_sched: fq: Fair Queue packet scheduler")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Diagnosed-by: Florian Westphal <fw@strlen.de>
Reported-by: syzbot+dc9071cc5a85950bdfce@syzkaller.appspotmail.com
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/net/llc_c_ac.h')
0 files changed, 0 insertions, 0 deletions