diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2012-03-10 11:58:18 +0400 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab@redhat.com> | 2012-03-19 22:45:01 +0400 |
| commit | 955b44304afca143b82304fe421e990ec607834a (patch) | |
| tree | f0046ed726b7c677d6d70d256c816573cb503932 /include/media | |
| parent | 23bfb5be9f4c14937d70ed09f24a19d86df1951b (diff) | |
| download | linux-955b44304afca143b82304fe421e990ec607834a.tar.xz | |
[media] gpio-ir-recv: a couple signedness bugs
There are couple places where we check unsigned values for negative. I
changed ->gpin_nr to signed because in gpio_ir_recv_probe() we do:
if (pdata->gpio_nr < 0)
return -EINVAL;
I also change gval to a signed int in gpio_ir_recv_irq() because that's
the type that gpio_get_value_cansleep() returns and we test for negative
returns.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Trilok Soni <tsoni@codeaurora.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Diffstat (limited to 'include/media')
| -rw-r--r-- | include/media/gpio-ir-recv.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/media/gpio-ir-recv.h b/include/media/gpio-ir-recv.h index 61a7fbb47127..67797bf5d432 100644 --- a/include/media/gpio-ir-recv.h +++ b/include/media/gpio-ir-recv.h @@ -14,7 +14,7 @@ #define __GPIO_IR_RECV_H__ struct gpio_ir_recv_platform_data { - unsigned int gpio_nr; + int gpio_nr; bool active_low; }; |