diff options
| author | Fabio M. De Francesco <fmdefrancesco@gmail.com> | 2023-06-02 13:33:07 +0300 |
|---|---|---|
| committer | Christian Brauner <brauner@kernel.org> | 2023-06-05 14:51:00 +0300 |
| commit | d0e135408e196921da2c85ee424235382c9ed614 (patch) | |
| tree | 9595921acfdd373fe63c79abc5a88d3adab3731e /include/linux | |
| parent | 79aa28494638f03a9e664163cb4620eb0482aaa2 (diff) | |
| download | linux-d0e135408e196921da2c85ee424235382c9ed614.tar.xz | |
highmem: Rename put_and_unmap_page() to unmap_and_put_page()
With commit 849ad04cf562a ("new helper: put_and_unmap_page()"), Al Viro
introduced the put_and_unmap_page() to use in those many places where we
have a common pattern consisting of calls to kunmap_local() +
put_page().
Obviously, first we unmap and then we put pages. Instead, the original
name of this helper seems to imply that we first put and then unmap.
Therefore, rename the helper and change the only known upstreamed user
(i.e., fs/sysv) before this helper enters common use and might become
difficult to find all call sites and instead easy to break the builds.
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Reviewed-by: Eric Biggers <ebiggers@google.com>
Message-Id: <20230602103307.5637-1-fmdefrancesco@gmail.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'include/linux')
| -rw-r--r-- | include/linux/highmem.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/highmem.h b/include/linux/highmem.h index 4de1dbcd3ef6..68da30625a6c 100644 --- a/include/linux/highmem.h +++ b/include/linux/highmem.h @@ -507,7 +507,7 @@ static inline void folio_zero_range(struct folio *folio, zero_user_segments(&folio->page, start, start + length, 0, 0); } -static inline void put_and_unmap_page(struct page *page, void *addr) +static inline void unmap_and_put_page(struct page *page, void *addr) { kunmap_local(addr); put_page(page); |