summaryrefslogtreecommitdiff
path: root/include/linux
diff options
context:
space:
mode:
authorGao Feng <gfree.wind@vip.163.com>2017-05-16 04:30:18 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-10-13 10:18:58 +0300
commitfcbd4cc28b190277f77d9a82c1e4d736224bc8c6 (patch)
tree99970bfe00e71d7dae27f489254952bd20d4f78c /include/linux
parent25f15a9283442a80b78de2d14ffe52666ea384eb (diff)
downloadlinux-fcbd4cc28b190277f77d9a82c1e4d736224bc8c6.tar.xz
ebtables: arpreply: Add the standard target sanity check
commit c953d63548207a085abcb12a15fefc8a11ffdf0a upstream. The info->target comes from userspace and it would be used directly. So we need to add the sanity check to make sure it is a valid standard target, although the ebtables tool has already checked it. Kernel needs to validate anything coming from userspace. If the target is set as an evil value, it would break the ebtables and cause a panic. Because the non-standard target is treated as one offset. Now add one helper function ebt_invalid_target, and we would replace the macro INVALID_TARGET later. Signed-off-by: Gao Feng <gfree.wind@vip.163.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Cc: Loic <hackurx@opensec.fr> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux')
-rw-r--r--include/linux/netfilter_bridge/ebtables.h5
1 files changed, 5 insertions, 0 deletions
diff --git a/include/linux/netfilter_bridge/ebtables.h b/include/linux/netfilter_bridge/ebtables.h
index 984b2112c77b..ea8a97793d2d 100644
--- a/include/linux/netfilter_bridge/ebtables.h
+++ b/include/linux/netfilter_bridge/ebtables.h
@@ -123,4 +123,9 @@ extern unsigned int ebt_do_table(struct sk_buff *skb,
/* True if the target is not a standard target */
#define INVALID_TARGET (info->target < -NUM_STANDARD_TARGETS || info->target >= 0)
+static inline bool ebt_invalid_target(int target)
+{
+ return (target < -NUM_STANDARD_TARGETS || target >= 0);
+}
+
#endif