diff options
author | Michael S. Tsirkin <mst@redhat.com> | 2015-12-17 13:20:39 +0300 |
---|---|---|
committer | Michael S. Tsirkin <mst@redhat.com> | 2016-01-12 21:47:02 +0300 |
commit | 788e5b3a5da24cc8d93ce2f7c6508181cd7d7fb6 (patch) | |
tree | 7e54e74c3f7373a04780ad14cb157089c76abeb2 /include/linux/virtio_ring.h | |
parent | 9e3f84ce416663c84a191cb3ead300fc1a4adadc (diff) | |
download | linux-788e5b3a5da24cc8d93ce2f7c6508181cd7d7fb6.tar.xz |
virtio_ring: use virt_store_mb
We need a full barrier after writing out event index, using
virt_store_mb there seems better than open-coding. As usual, we need a
wrapper to account for strong barriers.
It's tempting to use this in vhost as well, for that, we'll
need a variant of smp_store_mb that works on __user pointers.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Diffstat (limited to 'include/linux/virtio_ring.h')
-rw-r--r-- | include/linux/virtio_ring.h | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/include/linux/virtio_ring.h b/include/linux/virtio_ring.h index f3fa55bdd6ce..a156e2b6ccfe 100644 --- a/include/linux/virtio_ring.h +++ b/include/linux/virtio_ring.h @@ -45,6 +45,17 @@ static inline void virtio_wmb(bool weak_barriers) wmb(); } +static inline void virtio_store_mb(bool weak_barriers, + __virtio16 *p, __virtio16 v) +{ + if (weak_barriers) { + virt_store_mb(*p, v); + } else { + WRITE_ONCE(*p, v); + mb(); + } +} + struct virtio_device; struct virtqueue; |