summaryrefslogtreecommitdiff
path: root/include/linux/via-core.h
diff options
context:
space:
mode:
authorJohn Stultz <john.stultz@linaro.org>2015-05-08 23:47:23 +0300
committerThomas Gleixner <tglx@linutronix.de>2015-05-13 11:19:35 +0300
commitf7bcb70ebae0dcdb5a2d859b09e4465784d99029 (patch)
tree2a6a5386f7753172e3acc5b78874eeaeb1547401 /include/linux/via-core.h
parent030bbdbf4c833bc69f502eae58498bc5572db736 (diff)
downloadlinux-f7bcb70ebae0dcdb5a2d859b09e4465784d99029.tar.xz
ktime: Fix ktime_divns to do signed division
It was noted that the 32bit implementation of ktime_divns() was doing unsigned division and didn't properly handle negative values. And when a ktime helper was changed to utilize ktime_divns, it caused a regression on some IR blasters. See the following bugzilla for details: https://bugzilla.redhat.com/show_bug.cgi?id=1200353 This patch fixes the problem in ktime_divns by checking and preserving the sign bit, and then reapplying it if appropriate after the division, it also changes the return type to a s64 to make it more obvious this is expected. Nicolas also pointed out that negative dividers would cause infinite loops on 32bit systems, negative dividers is unlikely for users of this function, but out of caution this patch adds checks for negative dividers for both 32-bit (BUG_ON) and 64-bit(WARN_ON) versions to make sure no such use cases creep in. [ tglx: Hand an u64 to do_div() to avoid the compiler warning ] Fixes: 166afb64511e 'ktime: Sanitize ktime_to_us/ms conversion' Reported-and-tested-by: Trevor Cordes <trevor@tecnopolis.ca> Signed-off-by: John Stultz <john.stultz@linaro.org> Acked-by: Nicolas Pitre <nicolas.pitre@linaro.org> Cc: Ingo Molnar <mingo@kernel.org> Cc: Josh Boyer <jwboyer@redhat.com> Cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> Cc: <stable@vger.kernel.org> Link: http://lkml.kernel.org/r/1431118043-23452-1-git-send-email-john.stultz@linaro.org Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'include/linux/via-core.h')
0 files changed, 0 insertions, 0 deletions