diff options
| author | Eric Dumazet <edumazet@google.com> | 2015-11-05 22:07:13 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-11-05 22:36:09 +0300 |
| commit | 805c4bc05705fb2b71ec970960b456eee9900953 (patch) | |
| tree | 6e753b369a8f3663b5a50d3174b1a6fe0495714f /include/linux/tcp.h | |
| parent | 428ad1bc6dd766bb44171bba43a8a3219be77d2e (diff) | |
| download | linux-805c4bc05705fb2b71ec970960b456eee9900953.tar.xz | |
tcp: fix req->saved_syn race
For the reasons explained in commit ce1050089c96 ("tcp/dccp: fix
ireq->pktopts race"), we need to make sure we do not access
req->saved_syn unless we own the request sock.
This fixes races for listeners using TCP_SAVE_SYN option.
Fixes: e994b2f0fb92 ("tcp: do not lock listener to process SYN packets")
Fixes: 079096f103fa ("tcp/dccp: install syn_recv requests into ehash table")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Ying Cai <ycai@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/tcp.h')
| -rw-r--r-- | include/linux/tcp.h | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/include/linux/tcp.h b/include/linux/tcp.h index c906f4534581..b386361ba3e8 100644 --- a/include/linux/tcp.h +++ b/include/linux/tcp.h @@ -397,6 +397,13 @@ static inline void fastopen_queue_tune(struct sock *sk, int backlog) queue->fastopenq.max_qlen = min_t(unsigned int, backlog, somaxconn); } +static inline void tcp_move_syn(struct tcp_sock *tp, + struct request_sock *req) +{ + tp->saved_syn = req->saved_syn; + req->saved_syn = NULL; +} + static inline void tcp_saved_syn_free(struct tcp_sock *tp) { kfree(tp->saved_syn); |