diff options
| author | Alexey Dobriyan <adobriyan@gmail.com> | 2006-11-25 22:09:36 +0300 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.osdl.org> | 2006-11-26 00:28:34 +0300 |
| commit | ee3ce191e8eaa4cc15c51a28b34143b36404c4f5 (patch) | |
| tree | 557c5ade9b92e91f095e4017d97ffe7afd83383f /include/linux/spinlock_api_smp.h | |
| parent | 5e66b0b5f187c811419ff10cfb5668c028a64d57 (diff) | |
| download | linux-ee3ce191e8eaa4cc15c51a28b34143b36404c4f5.tar.xz | |
[PATCH] Enforce "unsigned long flags;" when spinlocking
Make it break or warn if you pass to spin_lock_irqsave() and friends
something different from "unsigned long flags;". Suprisingly large amount
of these was caught by recent commit
c53421b18f205c5f97c604ae55c6a921f034b0f6 and others.
Idea is largely from FRV typechecking. Suggestions from Andrew Morton.
All stupid typos in first version fixed.
Passes allmodconfig on i386, x86_64, alpha, arm as well as my usual config.
Note #1: checking with sparse is still needed, because a driver can save
and pass around flags or something. So far patch is very intrusive.
Note #2: techically, we should break only if
sizeof(flags) < sizeof(unsigned long),
however, the more pain for getting suspicious code into kernel,
the better.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'include/linux/spinlock_api_smp.h')
0 files changed, 0 insertions, 0 deletions