diff options
author | Emil Renner Berthing <kernel@esmil.dk> | 2019-04-12 13:53:20 +0300 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2019-05-08 13:32:28 +0300 |
commit | 47300728fb213486a830565d2af49da967c9d16a (patch) | |
tree | 5f07c2f74e4957e86fd437df0fa237e9ceb16e20 /include/linux/spi | |
parent | d5864e5bed96db7230da45463d6ae7af5b3b4399 (diff) | |
download | linux-47300728fb213486a830565d2af49da967c9d16a.tar.xz |
spi: rockchip: turn down tx dma bursts
This fixes tx and bi-directional dma transfers on rk3399-gru-kevin.
It seems the SPI fifo must have room for 2 bursts when the dma_tx_req
signal is generated or it might skip some words. This in turn makes
the rx dma channel never complete for bi-directional transfers.
Fix it by setting tx burst length to fifo_len / 4 and the dma
watermark to fifo_len / 2.
However the rk3399 TRM says (sic):
"DMAC support incrementing-address burst and fixed-address burst. But in
the case of access SPI and UART at byte or halfword size, DMAC only
support fixed-address burst and the address must be aligned to word."
So this relies on fifo_len being a multiple of 16 such that the
burst length (= fifo_len / 4) is a multiple of 4 and the addresses
will be word-aligned.
Fixes: dcfc861d24ec ("spi: rockchip: adjust dma watermark and burstlen")
Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'include/linux/spi')
0 files changed, 0 insertions, 0 deletions