summaryrefslogtreecommitdiff
path: root/include/linux/sonypi.h
diff options
context:
space:
mode:
authorRik van Riel <riel@surriel.com>2023-10-06 06:59:08 +0300
committerAndrew Morton <akpm@linux-foundation.org>2023-10-18 22:12:41 +0300
commit2820b0f09be99f6406784b03a22dfc83e858449d (patch)
treeace7c3d43420781b543bb61506bd98ee7fc557a0 /include/linux/sonypi.h
parentbf4916922c60f43efaa329744b3eef539aa6a2b2 (diff)
downloadlinux-2820b0f09be99f6406784b03a22dfc83e858449d.tar.xz
hugetlbfs: close race between MADV_DONTNEED and page fault
Malloc libraries, like jemalloc and tcalloc, take decisions on when to call madvise independently from the code in the main application. This sometimes results in the application page faulting on an address, right after the malloc library has shot down the backing memory with MADV_DONTNEED. Usually this is harmless, because we always have some 4kB pages sitting around to satisfy a page fault. However, with hugetlbfs systems often allocate only the exact number of huge pages that the application wants. Due to TLB batching, hugetlbfs MADV_DONTNEED will free pages outside of any lock taken on the page fault path, which can open up the following race condition: CPU 1 CPU 2 MADV_DONTNEED unmap page shoot down TLB entry page fault fail to allocate a huge page killed with SIGBUS free page Fix that race by pulling the locking from __unmap_hugepage_final_range into helper functions called from zap_page_range_single. This ensures page faults stay locked out of the MADV_DONTNEED VMA until the huge pages have actually been freed. Link: https://lkml.kernel.org/r/20231006040020.3677377-4-riel@surriel.com Fixes: 04ada095dcfc ("hugetlb: don't delete vma_lock in hugetlb MADV_DONTNEED processing") Signed-off-by: Rik van Riel <riel@surriel.com> Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com> Cc: Matthew Wilcox (Oracle) <willy@infradead.org> Cc: Muchun Song <muchun.song@linux.dev> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'include/linux/sonypi.h')
0 files changed, 0 insertions, 0 deletions