diff options
author | Eric Dumazet <edumazet@google.com> | 2012-06-13 13:45:16 +0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2012-06-16 02:30:15 +0400 |
commit | bc14786a100cc6a81cd060e8031ec481241b418c (patch) | |
tree | 344e33a1e1ee80906eb9aaaa339cd3bad257385a /include/linux/skbuff.h | |
parent | d9cb9bd63eb27ac19f26a8547128c053f43a5da8 (diff) | |
download | linux-bc14786a100cc6a81cd060e8031ec481241b418c.tar.xz |
bnx2x: fix panic when TX ring is full
There is a off by one error in the minimal number of BD in
bnx2x_start_xmit() and bnx2x_tx_int() before stopping/resuming tx queue.
A full size GSO packet, with data included in skb->head really needs
(MAX_SKB_FRAGS + 4) BDs, because of bnx2x_tx_split()
This error triggers if BQL is disabled and heavy TCP transmit traffic
occurs.
bnx2x_tx_split() definitely can be called, remove a wrong comment.
Reported-by: Tomas Hruby <thruby@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Eilon Greenstein <eilong@broadcom.com>
Cc: Yaniv Rosner <yanivr@broadcom.com>
Cc: Merav Sicron <meravs@broadcom.com>
Cc: Tom Herbert <therbert@google.com>
Cc: Robert Evans <evansr@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/skbuff.h')
0 files changed, 0 insertions, 0 deletions