summaryrefslogtreecommitdiff
path: root/include/linux/skbuff.h
diff options
context:
space:
mode:
authorRichard Cochran <richardcochran@gmail.com>2011-06-19 07:31:39 +0400
committerDavid S. Miller <davem@davemloft.net>2011-06-20 03:35:30 +0400
commit4ff75b7cf3b06efb72a50e26008d09b259b1231b (patch)
treef82bd4ee7ff91bbf66de846a4f601c26b549a3f9 /include/linux/skbuff.h
parentfd112f2e15ba85d387de446a81aeb11e46ecc55d (diff)
downloadlinux-4ff75b7cf3b06efb72a50e26008d09b259b1231b.tar.xz
net: correct comment on where to place transmit time stamp hook.
The comment for the skb_tx_timestamp() function suggests calling it just after a buffer is released to the hardware for transmission. However, for drivers that free the buffer in an ISR, this produces a race between the time stamp code and the ISR. This commit changes the comment to advise placing the call just before handing the buffer over to the hardware. Signed-off-by: Richard Cochran <richard.cochran@omicron.at> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/skbuff.h')
-rw-r--r--include/linux/skbuff.h3
1 files changed, 1 insertions, 2 deletions
diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index e8b78ce14474..f3af147c211d 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -2023,8 +2023,7 @@ static inline void sw_tx_timestamp(struct sk_buff *skb)
* skb_tx_timestamp() - Driver hook for transmit timestamping
*
* Ethernet MAC Drivers should call this function in their hard_xmit()
- * function as soon as possible after giving the sk_buff to the MAC
- * hardware, but before freeing the sk_buff.
+ * function immediately before giving the sk_buff to the MAC hardware.
*
* @skb: A socket buffer.
*/