diff options
author | Artur Paszkiewicz <artur.paszkiewicz@intel.com> | 2017-04-04 14:13:57 +0300 |
---|---|---|
committer | Shaohua Li <shli@fb.com> | 2017-04-10 22:00:49 +0300 |
commit | 845b9e229fe0716ab6b4d94b4364c99069667b59 (patch) | |
tree | 8c0ac896475505669b3f8665d053d2660d997e29 /include/linux/osq_lock.h | |
parent | 94568f64af50bb37c418b200449698cfe7e1da5f (diff) | |
download | linux-845b9e229fe0716ab6b4d94b4364c99069667b59.tar.xz |
raid5-ppl: use resize_stripes() when enabling or disabling ppl
Use resize_stripes() instead of raid5_reset_stripe_cache() to allocate
or free sh->ppl_page at runtime for all stripes in the stripe cache.
raid5_reset_stripe_cache() required suspending the mddev and could
deadlock because of GFP_KERNEL allocations.
Move the 'newsize' check to check_reshape() to allow reallocating the
stripes with the same number of disks. Allocate sh->ppl_page in
alloc_stripe() instead of grow_buffers(). Pass 'struct r5conf *conf' as
a parameter to alloc_stripe() because it is needed to check whether to
allocate ppl_page. Add free_stripe() and use it to free stripes rather
than directly call kmem_cache_free(). Also free sh->ppl_page in
free_stripe().
Set MD_HAS_PPL at the end of ppl_init_log() instead of explicitly
setting it in advance and add another parameter to log_init() to allow
calling ppl_init_log() without the bit set. Don't try to calculate
partial parity or add a stripe to log if it does not have ppl_page set.
Enabling ppl can now be performed without suspending the mddev, because
the log won't be used until new stripes are allocated with ppl_page.
Calling mddev_suspend/resume is still necessary when disabling ppl,
because we want all stripes to finish before stopping the log, but
resize_stripes() can be called after mddev_resume() when ppl is no
longer active.
Suggested-by: NeilBrown <neilb@suse.com>
Signed-off-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Signed-off-by: Shaohua Li <shli@fb.com>
Diffstat (limited to 'include/linux/osq_lock.h')
0 files changed, 0 insertions, 0 deletions