diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2013-11-07 11:48:49 +0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2013-11-08 04:11:13 +0400 |
| commit | df42153c59a38a65c6f7440d5c70d87d1c24438d (patch) | |
| tree | 3d928a77844d6c81e429e4cb5bc50097587ab805 /include/linux/netdevice.h | |
| parent | 78032f9b3eae3a43da9468d8ce30caa6be84f89d (diff) | |
| download | linux-df42153c59a38a65c6f7440d5c70d87d1c24438d.tar.xz | |
net: make ndev->irq signed for error handling
There is a bug in cpsw_probe() where we do:
ndev->irq = platform_get_irq(pdev, 0);
if (ndev->irq < 0) {
The problem is that "ndev->irq" is unsigned so the error handling
doesn't work. I have changed it to a regular int.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/netdevice.h')
| -rw-r--r-- | include/linux/netdevice.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index e6353cafbf05..b6f6efbcfc74 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -1132,7 +1132,7 @@ struct net_device { unsigned long mem_end; /* shared mem end */ unsigned long mem_start; /* shared mem start */ unsigned long base_addr; /* device I/O address */ - unsigned int irq; /* device IRQ number */ + int irq; /* device IRQ number */ /* * Some hardware also needs these fields, but they are not |