diff options
| author | Mel Gorman <mel@csn.ul.ie> | 2007-10-16 12:25:59 +0400 |
|---|---|---|
| committer | Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-10-16 20:43:00 +0400 |
| commit | 64c5e135bf5a2a7f0ededb3435a31adbe0202f0c (patch) | |
| tree | cb4ff93cbcc3c27176723419a313d7c53545d36b /include/linux/mmzone.h | |
| parent | ac0e5b7a6b93fb291b01fe1e951e3c16bcdd3503 (diff) | |
| download | linux-64c5e135bf5a2a7f0ededb3435a31adbe0202f0c.tar.xz | |
don't group high order atomic allocations
Grouping high-order atomic allocations together was intended to allow
bursty users of atomic allocations to work such as e1000 in situations
where their preallocated buffers were depleted. This did not work in at
least one case with a wireless network adapter needing order-1 allocations
frequently. To resolve that, the free pages used for min_free_kbytes were
moved to separate contiguous blocks with the patch
bias-the-location-of-pages-freed-for-min_free_kbytes-in-the-same-max_order_nr_pages-blocks.
It is felt that keeping the free pages in the same contiguous blocks should
be sufficient for bursty short-lived high-order atomic allocations to
succeed, maybe even with the e1000. Even if there is a failure, increasing
the value of min_free_kbytes will free pages as contiguous bloks in
contrast to the standard buddy allocator which makes no attempt to keep the
minimum number of free pages contiguous.
This patch backs out grouping high order atomic allocations together to
determine if it is really needed or not. If a new report comes in about
high-order atomic allocations failing, the feature can be reintroduced to
determine if it fixes the problem or not. As a side-effect, this patch
reduces by 1 the number of bits required to track the mobility type of
pages within a MAX_ORDER_NR_PAGES block.
Signed-off-by: Mel Gorman <mel@csn.ul.ie>
Acked-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux/mmzone.h')
| -rw-r--r-- | include/linux/mmzone.h | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h index 09b2c4f50e38..fef08c6cf75e 100644 --- a/include/linux/mmzone.h +++ b/include/linux/mmzone.h @@ -36,9 +36,8 @@ #define MIGRATE_UNMOVABLE 0 #define MIGRATE_RECLAIMABLE 1 #define MIGRATE_MOVABLE 2 -#define MIGRATE_HIGHATOMIC 3 -#define MIGRATE_RESERVE 4 -#define MIGRATE_TYPES 5 +#define MIGRATE_RESERVE 3 +#define MIGRATE_TYPES 4 #define for_each_migratetype_order(order, type) \ for (order = 0; order < MAX_ORDER; order++) \ |