diff options
| author | Alan Cox <alan@linux.intel.com> | 2012-02-28 18:49:23 +0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-03-08 22:50:35 +0400 |
| commit | 079c9534a96da9a85a2a2f9715851050fbfbf749 (patch) | |
| tree | 0e3782ff6d341f38c6f0b3840cb3c8f2bc922df8 /include/linux/keyboard.h | |
| parent | 0fb8379dab9f97e4c56de8f9ea772c10eda27561 (diff) | |
| download | linux-079c9534a96da9a85a2a2f9715851050fbfbf749.tar.xz | |
vt:tackle kbd_table
Keyboard struct lifetime is easy, but the locking is not and is completely
ignored by the existing code. Tackle this one head on
- Make the kbd_table private so we can run down all direct users
- Hoick the relevant ioctl handlers into the keyboard layer
- Lock them with the keyboard lock so they don't change mid keypress
- Add helpers for things like console stop/start so we isolate the poking
around properly
- Tweak the braille console so it still builds
There are a couple of FIXME locking cases left for ioctls that are so hideous
they should be addressed in a later patch. After this patch the kbd_table is
private and all the keyboard jiggery pokery is in one place.
This update fixes speakup and also a memory leak in the original.
Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/linux/keyboard.h')
| -rw-r--r-- | include/linux/keyboard.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/include/linux/keyboard.h b/include/linux/keyboard.h index 33a63f62d57f..86e5214ae735 100644 --- a/include/linux/keyboard.h +++ b/include/linux/keyboard.h @@ -24,8 +24,6 @@ #ifdef __KERNEL__ struct notifier_block; -extern const int NR_TYPES; -extern const int max_vals[]; extern unsigned short *key_maps[MAX_NR_KEYMAPS]; extern unsigned short plain_map[NR_KEYS]; |