diff options
| author | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2010-08-03 05:33:26 +0400 |
|---|---|---|
| committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2010-08-03 05:34:07 +0400 |
| commit | 0d87c7228a49e8342d60dd552892e470e0b291fa (patch) | |
| tree | 1282bcec7d8360d9f49b122fd3dca73f2787f47c /include/linux/input.h | |
| parent | 60347c194acec7ff1b4291ac8e62a5345244c2ee (diff) | |
| download | linux-0d87c7228a49e8342d60dd552892e470e0b291fa.tar.xz | |
Input: adp5588-keypad - fix NULL dereference in adp5588_gpio_add()
The kpad structure is assigned to i2c client via i2s_set_clientdata()
at the end of adp5588_probe(), but in adp5588_gpio_add() we tried to
access it (via dev_get_drvdata! which is not nice at all) causing an
oops.
Let's pass pointer to kpad directly into adp5588_gpio_add() and
adp5588_gpio_remove() to avoid accessing driver data before it is
set up.
Also split out building of gpiomap into a separate function to
clear the logic.
Reported-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Diffstat (limited to 'include/linux/input.h')
0 files changed, 0 insertions, 0 deletions