summaryrefslogtreecommitdiff
path: root/include/linux/dw_apb_timer.h
diff options
context:
space:
mode:
authorafzal mohammed <afzal.mohd.ma@gmail.com>2020-02-27 13:59:02 +0300
committerDaniel Lezcano <daniel.lezcano@linaro.org>2020-02-27 14:15:24 +0300
commitcc2550b421aa30e3da67e5a7f6d14f3ecd3527b3 (patch)
treea4ee1f7efee5a7a20477f46775a6c47ba2c74455 /include/linux/dw_apb_timer.h
parenta7cd39552194954bcdecfd9ff775466a61bda5bb (diff)
downloadlinux-cc2550b421aa30e3da67e5a7f6d14f3ecd3527b3.tar.xz
clocksource: Replace setup_irq() by request_irq()
request_irq() is preferred over setup_irq(). The early boot setup_irq() invocations happen either via 'init_IRQ()' or 'time_init()', while memory allocators are ready by 'mm_init()'. Per tglx[1], setup_irq() existed in olden days when allocators were not ready by the time early interrupts were initialized. Hence replace setup_irq() by request_irq(). Seldom remove_irq() usage has been observed coupled with setup_irq(), wherever that has been found, it too has been replaced by free_irq(). A build error that was reported by kbuild test robot <lkp@intel.com> in the previous version of the patch also has been fixed. [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail.com> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/91961c77c1cf93d41523f5e1ac52043f32f97077.1582799709.git.afzal.mohd.ma@gmail.com
Diffstat (limited to 'include/linux/dw_apb_timer.h')
-rw-r--r--include/linux/dw_apb_timer.h1
1 files changed, 0 insertions, 1 deletions
diff --git a/include/linux/dw_apb_timer.h b/include/linux/dw_apb_timer.h
index 14f072edbca5..82ebf9223948 100644
--- a/include/linux/dw_apb_timer.h
+++ b/include/linux/dw_apb_timer.h
@@ -25,7 +25,6 @@ struct dw_apb_timer {
struct dw_apb_clock_event_device {
struct clock_event_device ced;
struct dw_apb_timer timer;
- struct irqaction irqaction;
void (*eoi)(struct dw_apb_timer *);
};