diff options
author | Juergen Gross <jgross@suse.com> | 2017-07-28 17:53:55 +0300 |
---|---|---|
committer | Juergen Gross <jgross@suse.com> | 2017-08-11 17:45:56 +0300 |
commit | 529871bb3c0675d0b425e2070d5a739db097be98 (patch) | |
tree | 0422815a0e9fe13f44bebde0046b768569ea36e9 /include/drm/drm_encoder.h | |
parent | 4ca83dcf4e3bc0c98836dbb97553792ca7ea5429 (diff) | |
download | linux-529871bb3c0675d0b425e2070d5a739db097be98.tar.xz |
xen: avoid deadlock in xenbus
When starting the xenwatch thread a theoretical deadlock situation is
possible:
xs_init() contains:
task = kthread_run(xenwatch_thread, NULL, "xenwatch");
if (IS_ERR(task))
return PTR_ERR(task);
xenwatch_pid = task->pid;
And xenwatch_thread() does:
mutex_lock(&xenwatch_mutex);
...
event->handle->callback();
...
mutex_unlock(&xenwatch_mutex);
The callback could call unregister_xenbus_watch() which does:
...
if (current->pid != xenwatch_pid)
mutex_lock(&xenwatch_mutex);
...
In case a watch is firing before xenwatch_pid could be set and the
callback of that watch unregisters a watch, then a self-deadlock would
occur.
Avoid this by setting xenwatch_pid in xenwatch_thread().
Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
Diffstat (limited to 'include/drm/drm_encoder.h')
0 files changed, 0 insertions, 0 deletions