diff options
| author | Eric Biggers <ebiggers@google.com> | 2020-12-03 05:20:34 +0300 |
|---|---|---|
| committer | Eric Biggers <ebiggers@google.com> | 2020-12-03 05:25:01 +0300 |
| commit | 73114b6d28727b3f98b6a673c54c64b2c46ce4f5 (patch) | |
| tree | f095446dd1785385a541ec5ad6681466e8a4d12f /fs | |
| parent | 65f62515e9e55056a06c14a19150c1ea7760e2af (diff) | |
| download | linux-73114b6d28727b3f98b6a673c54c64b2c46ce4f5.tar.xz | |
f2fs: remove f2fs_dir_open()
Since encrypted directories can be opened and searched without their key
being available, and each readdir and ->lookup() tries to set up the
key, trying to set up the key in ->open() too isn't really useful.
Just remove it so that directories don't need an ->open() method
anymore, and so that we eliminate a use of fscrypt_get_encryption_info()
(which I'd like to stop exporting to filesystems).
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Link: https://lore.kernel.org/r/20201203022041.230976-3-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/f2fs/dir.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index 4b9ef8bbfa4a..47bee953fc8d 100644 --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.c @@ -1081,19 +1081,11 @@ out: return err < 0 ? err : 0; } -static int f2fs_dir_open(struct inode *inode, struct file *filp) -{ - if (IS_ENCRYPTED(inode)) - return fscrypt_get_encryption_info(inode) ? -EACCES : 0; - return 0; -} - const struct file_operations f2fs_dir_operations = { .llseek = generic_file_llseek, .read = generic_read_dir, .iterate_shared = f2fs_readdir, .fsync = f2fs_sync_file, - .open = f2fs_dir_open, .unlocked_ioctl = f2fs_ioctl, #ifdef CONFIG_COMPAT .compat_ioctl = f2fs_compat_ioctl, |