diff options
author | Mateusz Guzik <mguzik@redhat.com> | 2014-06-14 17:00:09 +0400 |
---|---|---|
committer | Ingo Molnar <mingo@kernel.org> | 2014-07-16 15:36:07 +0400 |
commit | b0ab99e7736af88b8ac1b7ae50ea287fffa2badc (patch) | |
tree | aee41b518d3cef411ebdf4bf385d28858a5fa759 /fs | |
parent | b6220ad66bcd4a50737eb3c08e9466aa44f3bc98 (diff) | |
download | linux-b0ab99e7736af88b8ac1b7ae50ea287fffa2badc.tar.xz |
sched: Fix possible divide by zero in avg_atom() calculation
proc_sched_show_task() does:
if (nr_switches)
do_div(avg_atom, nr_switches);
nr_switches is unsigned long and do_div truncates it to 32 bits, which
means it can test non-zero on e.g. x86-64 and be truncated to zero for
division.
Fix the problem by using div64_ul() instead.
As a side effect calculations of avg_atom for big nr_switches are now correct.
Signed-off-by: Mateusz Guzik <mguzik@redhat.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Cc: stable@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Link: http://lkml.kernel.org/r/1402750809-31991-1-git-send-email-mguzik@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'fs')
0 files changed, 0 insertions, 0 deletions